Jefffrey commented on PR #18698: URL: https://github.com/apache/datafusion/pull/18698#issuecomment-3536273782
> > > Closing this in favor of #18731 > > > > > > Please keep in mind we prefer keeping existing PRs instead of closing and opening new ones; it causes us to lose context and makes it harder for us to keep track (especially as for this tracking issue we have a _lot_ of PRs to keep track of in a short span of time) > > I understand but i made a mess in this one when I ran the `cargo test --test sqllogictests -- --complete` command for the test and it changed several files. The CI was still failing and it was becoming harder for me to track what broke it. If you could help track it down, it would be great help. Sorry for the inconvenience. As I mentioned before, I don't expect test changes to be necessary with these refactors. Please be conservative in the refactors being done and run tests as you do the refactor to ensure we don't break them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
