Jefffrey commented on code in PR #18750:
URL: https://github.com/apache/datafusion/pull/18750#discussion_r2531970685
##########
datafusion/common/src/types/native.rs:
##########
@@ -253,6 +251,8 @@ impl LogicalType for NativeType {
(Self::Interval(iu), _) => Interval(*iu),
(Self::Binary, LargeUtf8) => LargeBinary,
(Self::Binary, Utf8View) => BinaryView,
+ // We don't cast to another kind of binary type if the origin one
is already a binary type
+ (Self::Binary, Binary | LargeBinary | BinaryView) =>
origin.to_owned(),
Review Comment:
Same thing as we do for strings:
https://github.com/apache/datafusion/blob/fad5f8a628acc7db29ffed2c3faf7f1f35da5837/datafusion/common/src/types/native.rs#L266-L267
Looks like we just missed it for binary types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
