Jefffrey commented on code in PR #18719:
URL: https://github.com/apache/datafusion/pull/18719#discussion_r2532505900
##########
datafusion/physical-expr/src/projection.rs:
##########
@@ -47,6 +48,14 @@ pub struct ProjectionExpr {
pub alias: String,
}
+impl PartialEq for ProjectionExpr {
+ fn eq(&self, other: &Self) -> bool {
+ self.expr.eq(&other.expr) && self.alias == other.alias
Review Comment:
```suggestion
let ProjectionExpr { expr, alias } = self;
expr.eq(&other.expr) && alias == other.alias
```
In case we ever add fields to `ProjectionExpr` (however unlikely)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
