martin-g commented on code in PR #18769:
URL: https://github.com/apache/datafusion/pull/18769#discussion_r2534075491


##########
datafusion/functions-aggregate/src/sum.rs:
##########
@@ -130,7 +126,42 @@ pub struct Sum {
 impl Sum {
     pub fn new() -> Self {
         Self {
-            signature: Signature::user_defined(Volatility::Immutable),
+            // Refer to 
https://www.postgresql.org/docs/8.2/functions-aggregate.html doc
+            // smallint, int, bigint, real, double precision, decimal, or 
interval.

Review Comment:
   As you prefer!
   
   I just wondered why AVG supports Duration and SUM does not. To calculate the 
average it uses the sum ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to