Jefffrey commented on PR #17399: URL: https://github.com/apache/datafusion/pull/17399#issuecomment-3541929737
> Thank @Jefffrey For the plus replacement, the function is copied as it is from rust-url crate which is widely used. Do we still need to add test case for this case? > > Let me know if you have any suggestions Yes, we should still have a test case for this, preferably in an SLT case. Consider what happens if someone decides to refactor that code; there is currently no test case that would prevent them breaking it, I believe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
