rluvaton opened a new pull request, #18785:
URL: https://github.com/apache/datafusion/pull/18785
## Which issue does this PR close?
- Closes #18784.
## Rationale for this change
To be able to the failed tests
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Manually, by adding panic in the join like in the issue linked PR and saw
that it working for datafusion
Added panic in `sort_merge_join` and run:
```
RUST_BACKTRACE=1 cargo test --test sqllogictests -- join
```
<details>
<summary>Logs for running join slt tests (7 files)</summary>
```
Running bin/sqllogictests.rs
(target/debug/deps/sqllogictests-0092c8e14262530a)
[00:00:00] #####################------------------- 3/6
"join_lists.slt"
[00:00:00] #################----------------------- 12/30
"join_is_not_distinct_from.slt"
[00:00:00] #####----------------------------------- 10/81
"sort_merge_join.slt"
[00:00:00] ###------------------------------------- 12/224
"join_disable_repartition_joins.slt"
[00:00:00] ######---------------------------------- 11/81
"sort_merge_join.slt"
[00:00:00] ###############------------------------- 186/531
"joins.slt"
0: __rustc::rust_begin_unwind
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panicking.rs:698:5
1: core::panicking::panic_fmt
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/panicking.rs:75:14
2:
datafusion_physical_plan::joins::sort_merge_join::stream::SortMergeJoinStream::filter_record_batch_by_join_type
at
/Users/rluvaton/dev/open-source/apache/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs:1573:17
3:
datafusion_physical_plan::joins::sort_merge_join::stream::SortMergeJoinStream::filter_joined_batch
at
/Users/rluvaton/dev/open-source/apache/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs:1536:14
4:
<datafusion_physical_plan::joins::sort_merge_join::stream::SortMergeJoinStream
as futures_core::stream::Stream>::poll_next
at
/Users/rluvaton/dev/open-source/apache/datafusion/datafusion/physical-plan/src/joins/sort_merge_join/stream.rs:603:54
5: <core::pin::Pin<P> as futures_core::stream::Stream>::poll_next
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-core-0.3.31/src/stream.rs:130:33
6: <S as futures_core::stream::TryStream>::try_poll_next
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-core-0.3.31/src/stream.rs:206:14
7: <futures_util::stream::try_stream::try_collect::TryCollect<St,C> as
core::future::future::Future>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/stream/try_stream/try_collect.rs:46:47
8: datafusion_physical_plan::common::collect::{{closure}}
at
/Users/rluvaton/dev/open-source/apache/datafusion/datafusion/physical-plan/src/common.rs:43:36
9:
datafusion_sqllogictest::engines::datafusion_engine::runner::run_query::{{closure}}
at ./src/engines/datafusion_engine/runner.rs:144:53
10:
<datafusion_sqllogictest::engines::datafusion_engine::runner::DataFusion as
sqllogictest::runner::AsyncDB>::run::{{closure}}
at ./src/engines/datafusion_engine/runner.rs:94:84
11: <core::pin::Pin<P> as core::future::future::Future>::poll
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/future/future.rs:133:9
12: sqllogictest::runner::Runner<D,M>::apply_record::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sqllogictest-0.28.4/src/runner.rs:893:62
13: sqllogictest::runner::Runner<D,M>::run_async_no_retry::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sqllogictest-0.28.4/src/runner.rs:1031:56
14: sqllogictest::runner::Runner<D,M>::run_async::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/sqllogictest-0.28.4/src/runner.rs:1007:52
15: sqllogictests::run_file_in_runner::{{closure}}
at ./bin/sqllogictests.rs:366:52
16: sqllogictests::run_test_file::{{closure}}
at ./bin/sqllogictests.rs:345:60
17: sqllogictests::run_tests::{{closure}}::{{closure}}::{{closure}}
at ./bin/sqllogictests.rs:187:26
18: datafusion_common_runtime::trace_utils::trace_future::{{closure}}
at
/Users/rluvaton/dev/open-source/apache/datafusion/datafusion/common-runtime/src/trace_utils.rs:137:29
19: <core::pin::Pin<P> as core::future::future::Future>::poll
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/future/future.rs:133:9
20: <futures_util::future::future::map::Map<Fut,F> as
core::future::future::Future>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/future/future/map.rs:55:44
21: <futures_util::future::future::Map<Fut,F> as
core::future::future::Future>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/futures-util-0.3.31/src/lib.rs:86:35
22: <core::pin::Pin<P> as core::future::future::Future>::poll
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/future/future.rs:133:9
23: tokio::runtime::task::core::Core<T,S>::poll::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/core.rs:365:24
24: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/loom/std/unsafe_cell.rs:16:9
25: tokio::runtime::task::core::Core<T,S>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/core.rs:354:30
26: tokio::runtime::task::harness::poll_future::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:535:30
27: <core::panic::unwind_safe::AssertUnwindSafe<F> as
core::ops::function::FnOnce<()>>::call_once
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/panic/unwind_safe.rs:274:9
28: std::panicking::catch_unwind::do_call
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panicking.rs:590:40
29: ___rust_try
30: std::panicking::catch_unwind
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panicking.rs:553:19
31: std::panic::catch_unwind
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panic.rs:359:14
32: tokio::runtime::task::harness::poll_future
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:523:18
33: tokio::runtime::task::harness::Harness<T,S>::poll_inner
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:210:27
34: tokio::runtime::task::harness::Harness<T,S>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:155:20
35: tokio::runtime::task::raw::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/raw.rs:325:13
36: tokio::runtime::task::raw::RawTask::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/raw.rs:255:18
37: tokio::runtime::task::LocalNotified<S>::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/mod.rs:509:13
38:
tokio::runtime::scheduler::multi_thread::worker::Context::run_task::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:600:18
39: tokio::task::coop::with_budget
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/task/coop/mod.rs:167:5
40: tokio::task::coop::budget
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/task/coop/mod.rs:133:5
41: tokio::runtime::scheduler::multi_thread::worker::Context::run_task
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:591:9
42: tokio::runtime::scheduler::multi_thread::worker::Context::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:539:29
43:
tokio::runtime::scheduler::multi_thread::worker::run::{{closure}}::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:504:24
44: tokio::runtime::context::scoped::Scoped<T>::set
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/context/scoped.rs:40:9
45: tokio::runtime::context::set_scheduler::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/context.rs:176:38
46: std::thread::local::LocalKey<T>::try_with
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/thread/local.rs:315:12
47: std::thread::local::LocalKey<T>::with
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/thread/local.rs:279:20
48: tokio::runtime::context::set_scheduler
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/context.rs:176:17
49: tokio::runtime::scheduler::multi_thread::worker::run::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:499:9
50: tokio::runtime::context::runtime::enter_runtime
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/context/runtime.rs:65:16
51: tokio::runtime::scheduler::multi_thread::worker::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:491:5
52:
tokio::runtime::scheduler::multi_thread::worker::Launch::launch::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/scheduler/multi_thread/worker.rs:457:45
53: <tokio::runtime::blocking::task::BlockingTask<T> as
core::future::future::Future>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/blocking/task.rs:42:21
54: tokio::runtime::task::core::Core<T,S>::poll::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/core.rs:365:24
55: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/loom/std/unsafe_cell.rs:16:9
56: tokio::runtime::task::core::Core<T,S>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/core.rs:354:30
57: tokio::runtime::task::harness::poll_future::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:535:30
58: <core::panic::unwind_safe::AssertUnwindSafe<F> as
core::ops::function::FnOnce<()>>::call_once
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/core/src/panic/unwind_safe.rs:274:9
59: std::panicking::catch_unwind::do_call
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panicking.rs:590:40
60: ___rust_try
61: std::panicking::catch_unwind
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panicking.rs:553:19
62: std::panic::catch_unwind
at
/rustc/f8297e351a40c1439a467bbbb6879088047f50b3/library/std/src/panic.rs:359:14
63: tokio::runtime::task::harness::poll_future
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:523:18
64: tokio::runtime::task::harness::Harness<T,S>::poll_inner
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:210:27
65: tokio::runtime::task::harness::Harness<T,S>::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/harness.rs:155:20
66: tokio::runtime::task::raw::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/raw.rs:325:13
67: tokio::runtime::task::raw::RawTask::poll
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/raw.rs:255:18
68: tokio::runtime::task::UnownedTask<S>::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/task/mod.rs:546:13
69: tokio::runtime::blocking::pool::Task::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/blocking/pool.rs:161:19
70: tokio::runtime::blocking::pool::Inner::run
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/blocking/pool.rs:516:22
71: tokio::runtime::blocking::pool::Spawner::spawn_thread::{{closure}}
at
/Users/rluvaton/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.48.0/src/runtime/blocking/pool.rs:474:47
Completed 7 test files in 2 seconds
failure in sort_merge_join.slt for sql SELECT * FROM t1 RIGHT
JOIN t2 ON t1.a = t2.a AND t2.b * 50 <= t1.b
caused by
External error: task 19 panicked with message "test failing"
Error: Execution("1 failures")
error: test failed, to rerun pass `-p datafusion-sqllogictest --test
sqllogictests`
```
</details>
## Are there any user-facing changes?
Yes, added new struct for tracking running sql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
