adriangb commented on PR #18718: URL: https://github.com/apache/datafusion/pull/18718#issuecomment-3544039260
> > is it possible to add a high level test too? A query on a union array type that would hash it, like group by/distinct/aggregation as the body implies would be possible now > > I added some high-level tests [in a separate branch](https://github.com/apache/datafusion/compare/main...pydantic:datafusion:friendlymatthew/test-hash-union-arrays?expand=1) that exercise hashing union arrays through group by, distinct, aggregation queries > > Fwiw, this work is currently blocked by 2 upstream PRs in arrow-rs. But this PR can be reviewed by itself and can merge without any unwanted side effects > > * [Add support for `Union` types in `RowConverter` arrow-rs#8839](https://github.com/apache/arrow-rs/pull/8839) > * [Add comparison support for Union arrays arrow-rs#8838](https://github.com/apache/arrow-rs/pull/8838) Sounds good! @Jefffrey let us know if you would like to give a more in depth review or if you are okay with the changes, it wasn't clear to me from https://github.com/apache/datafusion/pull/18718#pullrequestreview-3470814558 if you plan to do so or not (thank you either way for looking at this!). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
