andygrove commented on code in PR #2791: URL: https://github.com/apache/datafusion-comet/pull/2791#discussion_r2536015650
########## spark/src/test/resources/tpcds-plan-stability/approved-plans-v1_4-spark4_0/q1/explain.txt: ########## @@ -1,49 +1,45 @@ == Physical Plan == -TakeOrderedAndProject (45) -+- * Project (44) - +- * BroadcastHashJoin Inner BuildRight (43) - :- * Project (37) - : +- * BroadcastHashJoin Inner BuildRight (36) - : :- * Project (30) - : : +- * BroadcastHashJoin Inner BuildRight (29) - : : :- * Filter (13) - : : : +- * HashAggregate (12) - : : : +- * CometColumnarToRow (11) Review Comment: This PR added support for `MakeDecimal` in ANSI mode, although we still need to add tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
