alamb commented on issue #18845: URL: https://github.com/apache/datafusion/issues/18845#issuecomment-3558547889
> The main challenge I see here is that all `ExprSchemable` methods have signatures like > > ``` > fn get_type(&self, schema: &dyn ExprSchema) -> Result<DataType>; > ``` > > where the result of the method is dependent on the `schema` argument. As a consequence you need to use that argument to validate the usability/correctness of the memoised result. In the proposed `ExprProperties` solution, I'm not sure how you would be able to do that. That is an excellent point. I think most times the schema should be the same, but I am not sure how to ensure that 🤔 Or maybe we need some way to "resolve" an Expr with a Schema and make some new type 🤔 Or I suppose we could put the memo table on the DFSchema itself maybe 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
