gabotechs commented on code in PR #18753:
URL: https://github.com/apache/datafusion/pull/18753#discussion_r2554930787
##########
datafusion/substrait/src/logical_plan/producer/expr/window_function.rs:
##########
@@ -100,20 +101,20 @@ fn make_substrait_window_function(
lower_bound: Some(bounds.0),
upper_bound: Some(bounds.1),
args: vec![],
- bounds_type: bounds_type as i32,
+ bounds_type: bounds_type.to_i32(),
Review Comment:
I imagine that if this is of type `BoundsTypeExt::Groups`, it will produce
invalid Substrait, as this is not yet supported in there
([link](https://github.com/substrait-io/substrait/blob/84816cd57e23b99b9e1816e1fffc740f121dbb22/proto/substrait/algebra.proto#L1301)).
I wonder if it's better to just fail if we find a `WindowFrameUnits::Groups`
until Substrait support groups bounds.
Probably worth opening an issue in
https://github.com/substrait-io/substrait, as I imagine the big bulk of the
work will need to happen there.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
