renato2099 commented on PR #18672:
URL: https://github.com/apache/datafusion/pull/18672#issuecomment-3573050199
> This is a good question. I did play around with doing some kind of
registry, but I don't think it necessarily fits the model we currently have of
how these structures are created and used.
>
> Take the `ExecutionPlan` for instance. Those typically only exist during
their execution and then get dropped when the strea is complete. If we had
registered those, we'd probably have an `Arc<dyn ExecutionPlan>` floating
around in the registry. That would lead to library memory bloat.
this is a fair point 👍
> There are other things one could use such a registry for. I haven't really
thought of any so I'm not sure how your suggestion would make the appoach more
future proof. Do you have a use case in mind already? If there's value add in
doing so, we can rework this PR but it would likely be more complex because I
suspect each one of these structs would need a custom registry.
I was thinking on a scenario where linking libraries would get us into
trouble, but I guess that is also not applicable for the work here.
thanks for the discussion @timsaucer !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
