iffyio commented on code in PR #2102:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2102#discussion_r2558892613
##########
tests/sqlparser_postgres.rs:
##########
@@ -6763,6 +6763,94 @@ fn parse_create_operator() {
assert!(pg().parse_sql_statements("CREATE OPERATOR > ())").is_err());
}
+#[test]
+fn parse_drop_operator() {
+ use sqlparser::ast::{DataType, DropBehavior, DropOperator,
DropOperatorSignature};
Review Comment:
Can we move the import to the top of the file?
##########
tests/sqlparser_postgres.rs:
##########
@@ -6763,6 +6763,94 @@ fn parse_create_operator() {
assert!(pg().parse_sql_statements("CREATE OPERATOR > ())").is_err());
}
+#[test]
+fn parse_drop_operator() {
+ use sqlparser::ast::{DataType, DropBehavior, DropOperator,
DropOperatorSignature};
+
+ // Test DROP OPERATOR with NONE for prefix operator
+ let sql = "DROP OPERATOR ~ (NONE, BIT)";
+ assert_eq!(
+ pg().verified_stmt(sql),
Review Comment:
```suggestion
pg_and_generic().verified_stmt(sql),
```
Any requirement to not use this instead for the tests? If not I think we can
use that version to cover the generic dialect behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
