ShashidharM0118 commented on PR #18763: URL: https://github.com/apache/datafusion/pull/18763#issuecomment-3592590067
I added a `distinct_ops` benchmark (`count_distinct_int64`, `count_distinct_float64`, `median_distinct_float64`, `percentile_cont_distinct_float64`) and ran it several times on both `main` and this branch. Results vary between runs (normal micro-benchmark noise on my machine), so I’m not confident claiming a clear regression or improvement from my local data alone. If possible, could you: - run `cargo bench -p datafusion-functions-aggregate --bench distinct_ops` on your side, and/or - suggest any specific benchmark setup you’d like (target time, sample count, etc.)? I’m happy to adjust the implementation or benches based on your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
