alamb commented on code in PR #19066:
URL: https://github.com/apache/datafusion/pull/19066#discussion_r2585638290
##########
datafusion/core/src/datasource/listing_table_factory.rs:
##########
@@ -453,22 +412,13 @@ mod tests {
let state = context.state();
let name = TableReference::bare("foo");
- let cmd = CreateExternalTable {
+ let cmd = CreateExternalTable::builder(
name,
- location: dir.path().to_str().unwrap().to_string(),
- file_type: "parquet".to_string(),
- schema: Arc::new(DFSchema::empty()),
- table_partition_cols: vec![],
- if_not_exists: false,
- or_replace: false,
- temporary: false,
- definition: None,
- order_exprs: vec![],
- unbounded: false,
- options: HashMap::new(),
- constraints: Constraints::default(),
- column_defaults: HashMap::new(),
- };
+ dir.path().to_str().unwrap().to_string(),
Review Comment:
Minor: You can probably avoid this to_string() as it already takes an `impl
Into<String>`
```suggestion
dir.path().to_str().unwrap(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
