andygrove commented on code in PR #2844:
URL: https://github.com/apache/datafusion-comet/pull/2844#discussion_r2586172258
##########
spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala:
##########
@@ -808,84 +755,45 @@ case class CometExecRule(session: SparkSession) extends
Rule[SparkPlan] {
}
/**
- * Convert a Spark plan operator to a protobuf Comet operator.
- *
- * @param op
- * Spark plan operator
- * @param childOp
- * previously converted protobuf Comet operators, which will be consumed
by the Spark plan
- * operator as its children
- * @return
- * The converted Comet native operator for the input `op`, or `None` if
the `op` cannot be
- * converted to a native operator.
+ * Fallback for handling sinks that have not been handled explicitly. This
method should
+ * eventually be removed once CometExecRule fully uses the operator serde
framework.
*/
private def operator2Proto(op: SparkPlan, childOp: Operator*):
Option[Operator] = {
+
+ def isCometSink(op: SparkPlan): Boolean = {
+ op match {
+ case _: CometSparkToColumnarExec => true
+ case _: CometSinkPlaceHolder => true
+ case _ => false
+ }
+ }
+
+ def isExchangeSink(op: SparkPlan): Boolean = {
Review Comment:
This method was moved without modification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
