alamb commented on code in PR #19077:
URL: https://github.com/apache/datafusion/pull/19077#discussion_r2588796213
##########
datafusion/sqllogictest/test_files/string/string_view.slt:
##########
@@ -370,7 +370,7 @@ EXPLAIN SELECT
FROM test;
----
logical_plan
-01)Projection: test.column1_utf8 LIKE Utf8("foo\%%") AS c1,
test.column1_large_utf8 LIKE LargeUtf8("foo\%%") AS c2, test.column1_utf8view
LIKE Utf8View("foo\%%") AS c3, test.column1_utf8 LIKE Utf8("f_o%") AS c4,
test.column1_large_utf8 LIKE LargeUtf8("f_o%") AS c5, test.column1_utf8view
LIKE Utf8View("f_o%") AS c6
+01)Projection: test.column1_utf8 LIKE Utf8("foo\%%") AS c1,
test.column1_large_utf8 LIKE LargeUtf8("foo\%%") AS c2, test.column1_utf8view
LIKE Utf8View("foo\%%") AS c3, test.column1_utf8 LIKE Utf8("f\_o%") AS c4,
test.column1_large_utf8 LIKE LargeUtf8("f\_o%") AS c5, test.column1_utf8view
LIKE Utf8View("f\_o%") AS c6
Review Comment:
🤦 -- `_` matches exactly one character -- so escaping them is the right
thing to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
