harshitsaini17 commented on PR #19197: URL: https://github.com/apache/datafusion/pull/19197#issuecomment-3625386000
Hi @rluvaton ! I'm seeing a CI formatting error in [const_evaluator.rs](https://github.com/apache/datafusion/blob/main/datafusion/physical-expr/src/simplifier/const_evaluator.rs) on my PR branch. However, this file is not part of my changes - I only modified: [bit_count.rs](https://github.com/apache/datafusion/blob/main/datafusion/spark/src/function/bitwise/bit_count.rs) The formatting error appears to have come from merging the upstream main branch into my feature branch to keep it up-to-date. Question: Should I: Fix the formatting issue in [const_evaluator.rs](vscode-file://vscode-app/opt/visual-studio-code/resources/app/out/vs/code/electron-browser/workbench/workbench.html) as part of this PR (even though it's unrelated to my changes)? Revert the merge commit and rebase instead to avoid including this issue? Wait for the formatting issue to be fixed in main first, then rebase my branch? I want to make sure I follow the correct contribution workflow. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
