alamb commented on code in PR #19137:
URL: https://github.com/apache/datafusion/pull/19137#discussion_r2598637924
##########
datafusion/datasource/src/table_schema.rs:
##########
@@ -70,7 +70,7 @@ pub struct TableSchema {
///
/// These columns are NOT present in the data files but are appended to
each
/// row during query execution based on the file's location.
- table_partition_cols: Vec<FieldRef>,
+ table_partition_cols: Arc<Vec<FieldRef>>,
Review Comment:
I recommend we use
https://docs.rs/arrow/latest/arrow/datatypes/struct.Fields.html (which is
already basically Arc<Vec<FieldRef>>) but can be constructed zero copy
potentially from existing schemas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
