theirix commented on PR #17843: URL: https://github.com/apache/datafusion/pull/17843#issuecomment-3628680328
> Since we're actually keeping the three examples, I've refactored them to be clearer and hopefully easier to understand. (Although I have doubts on the match_recognize one, as it doesn't bring anything new that table_sample doesn't. I'd be in favor in removing it.) > > @theirix would you mind reviewing the table_sample example again? In particular, I removed the Poisson distribution as it can't really be called from standard SQL without hacking (no `POISSON` or `WITH REPLACEMENT` clause.) Absolutely! I will have a look and rereview soon. Given that this PR includes a great table sample implementation on an extensible foundation, my previous PR to do the same in #17633 (and the first attempt #16325) would be less relevant. @alamb, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
