pepijnve opened a new issue, #19286: URL: https://github.com/apache/datafusion/issues/19286
### Describe the bug In `GroupedHashAggregateStream::spill_previous_if_necessary`, when the `group_ordering` is not `GroupOrdering::None`, spilling is currently not supported. In `GroupedHashAggregateStream::group_aggregate_batch`, there is code that ignores out of memory errors under the assumption that spilling will kick in the next time `spill_previous_if_necessary` is called. The optimistic check in `group_aggregate_batch` is out of sync with `spill_previous_if_necessary` though causing out of memory errors to be ignored even when spilling is not possible. ### To Reproduce Test case added in associated PR ### Expected behavior When spilling is not possible the memory pool size is respected. ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
