andygrove commented on code in PR #2879:
URL: https://github.com/apache/datafusion-comet/pull/2879#discussion_r2611389447
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -199,17 +171,18 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] with Com
// Spark already converted these to Java-native types, so we can't
check SQL types.
// ArrayBasedMapData, GenericInternalRow, GenericArrayData
correspond to maps, structs,
// and arrays respectively.
- fallbackReasons +=
- "Full native scan disabled because nested types for default values
are not supported"
- return withInfos(scanExec, fallbackReasons.toSet)
+ withInfo(
+ scanExec,
+ "Full native scan disabled because nested types for default values
are not supported")
}
if (encryptionEnabled(hadoopConf) && scanImpl !=
CometConf.SCAN_NATIVE_COMET) {
if (!isEncryptionConfigSupported(hadoopConf)) {
- return withInfos(scanExec, fallbackReasons.toSet)
Review Comment:
It looks like `fallbackReasons` was always an empty set here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
