milenkovicm commented on PR #19267: URL: https://github.com/apache/datafusion/pull/19267#issuecomment-3646702685
I agree with you it's hard problem to crack. I'm not sure about macros, maybe. If we need to explain how to use the API, maybe we overcomplicate it. Would `[before|after]_[encode|decode]_[plan|expr]` where `before` can return either `proceed` or `stop` result which would then trigger default method recurssion? They could have a default implementation, plus users who do not need such functionality will never need to implement it. We would have like eight new methods, which increase API complexity but not necessarily by too much as they will have a default implementation. or if `[encode|decode]_[plan|expr]` return some kind of "aspect" instance which would go to recursion rather than codec itself would help I'm just throwing ideas, trying to help, will have a look tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
