alamb commented on code in PR #18542:
URL: https://github.com/apache/datafusion/pull/18542#discussion_r2615115744
##########
.github/workflows/rust.yml:
##########
@@ -587,10 +587,12 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- - name: Run
+ - name: Setup nightly Rust toolchain
+ run: rustup toolchain install nightly --component rustfmt
+ - name: Run cargo fmt check (including doc comments)
run: |
echo '' > datafusion/proto/src/generated/datafusion.rs
- ci/scripts/rust_fmt.sh
+ cargo +nightly fmt --all -- --check --config
format_code_in_doc_comments=true
Review Comment:
Can you please update the `ci/scripts/rust_fmt.sh` script instead? That way
it will be easier for people to run the checks locally (rather than having to
find the commands in the github jobs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
