andygrove commented on PR #2872: URL: https://github.com/apache/datafusion-comet/pull/2872#issuecomment-3648723683
> I am putting this on hold for now because I have a better understanding of some of the points in the original issue, and I have learned more from another issue that I have been working on. I will add notes on the issue. @parthchandra @comphead @mbutrovich This is now ready for review. This PR is step 1 of TBD (probably 2-3). With this PR, Comet consistently falls back if either partial or final agg cannot be converted. We were already doing this in some cases, and this PR makes it more consistent and adds tests. Note that Comet is falling back even when it isn't necessary. This PR doesn't change that, so there will be a future PR to fall back only if there is actually an incompatibility between Comet/Spark for the intermediate aggregation buffer (such as with bloom filters and ANSI mode numeric aggregates currently), rather than always falling back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
