Yuvraj-cyborg commented on PR #19298: URL: https://github.com/apache/datafusion/pull/19298#issuecomment-3649034950
@BlakeOrth I did the changes you asked but for the last one , but if we change ```Option<Path>``` to ```Option<&Path>``` , we need to change ```CacheAccessor``` trait's ```Extra``` type to be a reference and there can be complexity in lifetimes... Again just an opinion If think that's a better architecture then would change it ! Guess I as well need to spend more time with the codebase . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
