Jefffrey commented on code in PR #19310:
URL: https://github.com/apache/datafusion/pull/19310#discussion_r2616686970
##########
datafusion/optimizer/src/push_down_limit.rs:
##########
@@ -81,7 +81,7 @@ impl OptimizerRule for PushDownLimit {
});
// recursively reapply the rule on the new plan
- #[allow(clippy::used_underscore_binding)]
+ #[expect(clippy::used_underscore_binding)]
Review Comment:
Ditto
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -811,7 +811,7 @@ impl OptimizerRule for PushDownFilter {
new_predicate,
child_filter.input,
)?);
- #[allow(clippy::used_underscore_binding)]
+ #[expect(clippy::used_underscore_binding)]
Review Comment:
Can we fix the code here to not need this expect?
##########
datafusion/ffi/src/expr/distribution.rs:
##########
@@ -29,7 +29,7 @@ use datafusion_expr::statistics::{
#[repr(C)]
#[derive(Debug, StableAbi)]
#[allow(non_camel_case_types)]
-#[expect(clippy::large_enum_variant)]
+#[allow(clippy::large_enum_variant)]
Review Comment:
For FFI I think we're missing the deny at the lib.rs level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
