andygrove commented on code in PR #2925:
URL: https://github.com/apache/datafusion-comet/pull/2925#discussion_r2625348185
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -684,22 +684,73 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
- ignore("cast StringType to DecimalType(10,2)") {
- // https://github.com/apache/datafusion-comet/issues/325
- val values = gen.generateStrings(dataSize, numericPattern, 8).toDF("a")
- castTest(values, DataTypes.createDecimalType(10, 2))
+ test("cast StringType to DecimalType(10,2)") {
+ // TODO fix for Spark 4.0.0
+ assume(!isSpark40Plus)
Review Comment:
What is the issue with Spark 4? Do we need to file a new issue and reference
it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
