pepijnve commented on code in PR #19360:
URL: https://github.com/apache/datafusion/pull/19360#discussion_r2627135388
##########
datafusion/physical-plan/src/joins/sort_merge_join/exec.rs:
##########
@@ -496,7 +497,7 @@ impl ExecutionPlan for SortMergeJoinExec {
.register(context.memory_pool());
// create join stream
- Ok(Box::pin(SortMergeJoinStream::try_new(
+ Ok(make_cooperative(Box::pin(SortMergeJoinStream::try_new(
Review Comment:
In this kind of situation, you can use
```
Box::pin(cooperative(SortMergeJoinStream::try_new...
```
instead. This avoids one level of pointer indirection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
