iffyio commented on code in PR #2134:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2134#discussion_r2631929918
##########
src/parser/mod.rs:
##########
@@ -15188,6 +15137,11 @@ impl<'a> Parser<'a> {
let func_name = self.parse_object_name(true)?;
let func = self.parse_function(func_name)?;
return Ok(Some(TableVersion::Function(func)));
+ } else if dialect_of!(self is DatabricksDialect)
Review Comment:
Yeah its fine for the parser to be permissive and accept sql statements for
a dialect that wouldn't necessarily be supported by the dialect (downstream
crates are expected to validate the returned AST if the behavior is undesirable
for a specific use case), so that e.g. having bigquery accept the 'TIMESTAMP AS
OF' would be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
