bubulalabu commented on code in PR #19308: URL: https://github.com/apache/datafusion/pull/19308#discussion_r2642801622
########## datafusion/sqllogictest/test_files/named_arguments.slt: ########## @@ -269,3 +269,80 @@ SELECT row_number(value => 1) OVER (ORDER BY id) FROM window_test; # Cleanup statement ok DROP TABLE window_test; + +############# +## Test UDF with Many Optional Parameters (test_optional_params - sums p1 through p7) Review Comment: Yes, there's an overlap between the SLTs and the unit tests. What kind is generally preferred? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
