zhuqi-lucas commented on code in PR #19446:
URL: https://github.com/apache/datafusion/pull/19446#discussion_r2645206963
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -603,6 +604,27 @@ impl ExecutionPlan for FilterExec {
})
}
+ fn try_pushdown_sort(
Review Comment:
Thanks @adriangb for review, i agree, but currently i think it's good, i
only add the following 3 basic cases, and don't add specific sort pushdown,
just bypass to child sort pushdown to make it work:
```rust
FilterExec::try_pushdown_sort
ProjectionExec::try_pushdown_sort
CooperativeExec::try_pushdown_sort
```
And they all just bypass self to the child sort pushdown, i was testing and
also the new slt testing here, it seems need this, and they are the basic cases
i think.
I also created a issue for the following operators to add more
try_pushdown_sort implementation, we can investigate more for it:
https://github.com/apache/datafusion/issues/19394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
