theirix commented on code in PR #19311:
URL: https://github.com/apache/datafusion/pull/19311#discussion_r2645916984
##########
datafusion-examples/examples/relation_planner/main.rs:
##########
@@ -90,7 +90,7 @@ async fn main() -> Result<()> {
let example: ExampleKind = std::env::args()
.nth(1)
- .ok_or_else(|| DataFusionError::Execution(format!("Missing argument.
{usage}")))?
+ .unwrap_or_else(|| ExampleKind::All.to_string())
Review Comment:
I agree, this change shouldn't belong to this PR. I wanted to keep the
original behaviour of running tests via classic `cargo run --example
relation_planner` compared to `cargo run --example relation_planner -- all`. If
it makes sense, I can make a consistent change for all examples in a separate
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
