comphead commented on code in PR #2929:
URL: https://github.com/apache/datafusion-comet/pull/2929#discussion_r2646262452
##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -369,9 +369,11 @@ fn is_hdfs_scheme(url: &Url, object_store_configs:
&HashMap<String, String>) ->
}
}
-// Mirrors object_store::parse::parse_url for the hdfs object store
-#[cfg(feature = "hdfs")]
-fn parse_hdfs_url(url: &Url) -> Result<(Box<dyn ObjectStore>, Path),
object_store::Error> {
+// Creates an HDFS object store from a URL using the native HDFS implementation
+#[cfg(all(feature = "hdfs", not(feature = "hdfs-opendal")))]
+fn create_hdfs_object_store(
Review Comment:
renamed from `parse_hdfs_url` to reflect more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
