EmilyMatt commented on code in PR #19494:
URL: https://github.com/apache/datafusion/pull/19494#discussion_r2647208231
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -853,15 +860,7 @@ pub fn sort_batch(
.collect::<Result<Vec<_>>>()?;
let indices = lexsort_to_indices(&sort_columns, fetch)?;
- let mut columns = take_arrays(batch.columns(), &indices, None)?;
-
- // The columns may be larger than the unsorted columns in `batch`
especially for variable length
Review Comment:
This is not really needed as take actually uses the offsets for variable
length columns.
At worst the buffers themselves will be rounded up to the 64 byte multiplier
to optimize SIMD operations, but that is actually desirable and not something
we want to mess with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
