kumarUjjawal commented on issue #19408: URL: https://github.com/apache/datafusion/issues/19408#issuecomment-3692784305
> [datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs](https://github.com/apache/datafusion/blob/058bcb0014eae420675dad549f9a263a4eeb96f1/datafusion/physical-plan/src/joins/join_hash_map.rs#L98-L103) > > Lines 98 to 103 in [058bcb0](/apache/datafusion/commit/058bcb0014eae420675dad549f9a263a4eeb96f1) > > /// ## Note on use of this trait as a public API > /// This is currently a public trait but is mainly intended for internal use within DataFusion. > /// For example, we may compare references to `JoinHashMapType` implementations by pointer equality > /// rather than deep equality of contents, as deep equality would be expensive and in our usage > /// patterns it is impossible for two different hash maps to have identical contents in a practical sense. > pub trait JoinHashMapType: Send + Sync { > Seems we already have a comment to this effect? Yes, that's what I found. My inital intention was to ask if this change of making `JoinHashMapType` `pub(crate)` something we want to go forward with even thoug it is a breaking change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
