Jefffrey commented on PR #19491: URL: https://github.com/apache/datafusion/pull/19491#issuecomment-3693945163
> > Is the intention to eventually have two scripts, one to check and one to generate? They seem quite similar, and I think a common pattern we have is to only have the generate script, then in CI we rerun the generate script and do a `git diff` to ensure they are matching. > > Good point, thanks for calling this out. > > It makes sense to rely on a single generate script and have CI re-run it and check for diffs, rather than maintaining separate generate and check logic. > > I can update this PR to drop the standalone check script and wire CI to run `generate_examples_docs.sh` and fail on git diff instead. That sounds good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
