rluvaton commented on code in PR #19494:
URL: https://github.com/apache/datafusion/pull/19494#discussion_r2650959969
##########
datafusion/physical-plan/src/sorts/multi_level_merge.rs:
##########
@@ -360,9 +360,9 @@ impl MultiLevelMergeBuilder {
for spill in &self.sorted_spill_files {
// For memory pools that are not shared this is good, for other
this is not
// and there should be some upper limit to memory reservation so
we won't starve the system
- match reservation.try_grow(get_reserved_byte_for_record_batch_size(
- spill.max_record_batch_memory * buffer_len,
- )) {
+ match reservation.try_grow(
+ round_upto_multiple_of_64(spill.max_record_batch_memory) *
buffer_len,
+ ) {
Review Comment:
This now doesn't account for SortPreservingMergeStream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
