adriangb commented on PR #18938: URL: https://github.com/apache/datafusion/pull/18938#issuecomment-3696700131
> 👋 I think I found the issue, in short, we should check the strong count of the inner struct not the DynamicFilterPhysicalExpr 🤦♀️ since sometimes new DynamicFilterPhysicalExpr are created but still keep the same `inner` struct reference. I will push the updated commit in the same PR in a moment Ahhh yep that sounds right to me! E.g. `with_new_children` will create a new `Arc<DynamicFilterPhysicalExpr>` but the inner reference is what matters 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
