adriangb commented on code in PR #19557:
URL: https://github.com/apache/datafusion/pull/19557#discussion_r2653019436
##########
datafusion/datasource-parquet/src/sort.rs:
##########
@@ -153,7 +166,10 @@ mod tests {
let selection =
RowSelection::from(vec![RowSelector::select(50),
RowSelector::skip(250)]);
- let reversed = reverse_row_selection(&selection, &metadata).unwrap();
+ let row_groups_to_scan = vec![0, 1, 2];
Review Comment:
My point was more so that we should be testing closer to the production code
path, which I think involves building a `PreparedAccessPlan` and calling
`PreparedAccessPlan::reverse`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
