abhiaagarwal commented on PR #19565: URL: https://github.com/apache/datafusion/pull/19565#issuecomment-3706453088
> > > Why a new trait if we already have `LogicalPlanBuilder`? > > > > > > I'm fine with adding it to `LogicalPlanBuilder`, just trying to be conservative > > Maybe I'm missing something but in what way is adding a new trait (that will probably only ever be implemented for a single struct that we own) more conservative than just adding the methods to the struct? Nothing at all. The honest real reason was because I plucked this from a [PR](https://github.com/delta-io/delta-rs/pull/4024/changes#diff-f83539dbd6df98c12a5e89efb1e8f839b6e464a0969332c7d09da16f5347da4fR73) I opened in delta-rs to upstream. I'd be totally fine with making them as methods :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
