GaneshPatil7517 commented on PR #19688: URL: https://github.com/apache/datafusion/pull/19688#issuecomment-3729790857
> Honestly I do not have confidence in this PR especially considering the issue it tackles. > > * It is bleeding in changes from other PRs (#19618) > * It claims to close the issue (#19511) but this only addresses aggregate UDFs > * It includes details in the PR body like saying `COUNT` should be fixed but doesn't attempt that in this PR > * There's small issues like how it deprecates from version 42 or the liberal use of `#[allow(...)]` which would be caught if clippy was run > > All these lead me to think that proper consideration hasn't been given to this PR so I am not very inclined towards it. I feel a lot of this code is generated by an LLM and hasn't been disclosed, or even tested. no i was beginner in opensource, and actually what happened i mistakable pushed code of the another issue i did not created branch.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
