LiaCastaneda commented on issue #19715: URL: https://github.com/apache/datafusion/issues/19715#issuecomment-3729914428
👋 @tobixdev the `inner` struct of `DynamicFilterPhysicalExpr` gets updated (the ref count increases from 1 to 2) when we call `with_new_children` during the filter pushdown optimization rule. I'm trying to understand why `with_new_children` is not being called for your query 🤔 this might be an edge case I overlooked. The reason why I didn't used the strong count of `DynamicFilterPhysicalExpr` is precisely because when [with_new_children](https://github.com/apache/datafusion/blob/209a0a2e86dda54e7dc00f5715ed1e35ea1af3cb/datafusion/physical-expr/src/expressions/dynamic_filters.rs#L357) is called for `DynamicFilterPhysicalExpr` it creates a new `DynamicFilterPhysicalExpr` but keeps the Arc of the `inner` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
