viirya commented on code in PR #19635:
URL: https://github.com/apache/datafusion/pull/19635#discussion_r2678456984


##########
datafusion/sqllogictest/test_files/tpch/plans/q16.slt.part:
##########
@@ -71,17 +71,18 @@ physical_plan
 04)------AggregateExec: mode=FinalPartitioned, gby=[p_brand@0 as p_brand, 
p_type@1 as p_type, p_size@2 as p_size], aggr=[count(alias1)]
 05)--------RepartitionExec: partitioning=Hash([p_brand@0, p_type@1, p_size@2], 
4), input_partitions=4
 06)----------AggregateExec: mode=Partial, gby=[p_brand@0 as p_brand, p_type@1 
as p_type, p_size@2 as p_size], aggr=[count(alias1)]
-07)------------AggregateExec: mode=SinglePartitioned, gby=[p_brand@1 as 
p_brand, p_type@2 as p_type, p_size@3 as p_size, ps_suppkey@0 as alias1], 
aggr=[]
-08)--------------HashJoinExec: mode=Partitioned, join_type=LeftAnti, 
on=[(ps_suppkey@0, s_suppkey@0)]
-09)----------------RepartitionExec: partitioning=Hash([ps_suppkey@0], 4), 
input_partitions=4
-10)------------------HashJoinExec: mode=Partitioned, join_type=Inner, 
on=[(ps_partkey@0, p_partkey@0)], projection=[ps_suppkey@1, p_brand@3, 
p_type@4, p_size@5]
-11)--------------------RepartitionExec: partitioning=Hash([ps_partkey@0], 4), 
input_partitions=4
-12)----------------------DataSourceExec: file_groups={4 groups: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/partsupp.tbl:0..2932049],
 
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/partsupp.tbl:2932049..5864098],
 
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/partsupp.tbl:5864098..8796147],
 
[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/partsupp.tbl:8796147..11728193]]},
 projection=[ps_partkey, ps_suppkey], file_type=csv, has_header=false
-13)--------------------RepartitionExec: partitioning=Hash([p_partkey@0], 4), 
input_partitions=4
-14)----------------------FilterExec: p_brand@1 != Brand#45 AND p_type@2 NOT 
LIKE MEDIUM POLISHED% AND p_size@3 IN (SET) ([49, 14, 23, 45, 19, 3, 36, 9])
-15)------------------------RepartitionExec: partitioning=RoundRobinBatch(4), 
input_partitions=1
-16)--------------------------DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/part.tbl]]}, 
projection=[p_partkey, p_brand, p_type, p_size], file_type=csv, has_header=false
-17)----------------RepartitionExec: partitioning=Hash([s_suppkey@0], 4), 
input_partitions=4
-18)------------------FilterExec: s_comment@1 LIKE %Customer%Complaints%, 
projection=[s_suppkey@0]
-19)--------------------RepartitionExec: partitioning=RoundRobinBatch(4), 
input_partitions=1
-20)----------------------DataSourceExec: file_groups={1 group: 
[[WORKSPACE_ROOT/datafusion/sqllogictest/test_files/tpch/data/supplier.tbl]]}, 
projection=[s_suppkey, s_comment], file_type=csv, has_header=false
+07)------------AggregateExec: mode=FinalPartitioned, gby=[p_brand@0 as 
p_brand, p_type@1 as p_type, p_size@2 as p_size, alias1@3 as alias1], aggr=[]
+08)--------------RepartitionExec: partitioning=Hash([p_brand@0, p_type@1, 
p_size@2, alias1@3], 4), input_partitions=4
+09)----------------AggregateExec: mode=Partial, gby=[p_brand@1 as p_brand, 
p_type@2 as p_type, p_size@3 as p_size, ps_suppkey@0 as alias1], aggr=[]
+10)------------------HashJoinExec: mode=CollectLeft, join_type=LeftAnti, 
on=[(ps_suppkey@0, s_suppkey@0)]

Review Comment:
   From the benchmarks, looks like q16 has no regression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to