killzoner commented on PR #1374: URL: https://github.com/apache/datafusion-ballista/pull/1374#issuecomment-3732487958
> thanks @killzoner i think changes make sense. My major comment for discussion if validation should be runtime configuration rather than compile time, I'm leaning towards later, but open for discussion I pretty much replicated existing config setup, but a compile time config makes sense, as it's a strong default not supposed to be changed frequently. I will put this specific config under a new feature gate, part of the default features. If you have a name in mind don't hesitate 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
