Jefffrey commented on code in PR #19745:
URL: https://github.com/apache/datafusion/pull/19745#discussion_r2679465239


##########
datafusion/substrait/Cargo.toml:
##########
@@ -42,7 +42,8 @@ half = { workspace = true }
 itertools = { workspace = true }
 object_store = { workspace = true }
 pbjson-types = { workspace = true }
-prost = { workspace = true }
+# We need to match the version in substrait, so we don't use the workspace 
version here
+prost = { version = "0.8.0" }

Review Comment:
   Substrait hasn't upgraded to 0.9.0 yet:
   
   - https://github.com/substrait-io/substrait-rs/pull/433
   
   (We'd need version bump from substrait anyway)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to