gabotechs commented on PR #19761: URL: https://github.com/apache/datafusion/pull/19761#issuecomment-3749930023
> Big picture question: could this be part of the HashJoinExec code? Potentially yes, although I do see value in having this be its own node, that way we can: - collect metrics associated to it independently to the hash join node - use it in more places This is actually something we (DataDog) have had for a long time, we have a similar `BufferExec` node that we decide to place not only on probe side of hash joins, but also in other places for other parts of our plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
