kosiew commented on PR #19674:
URL: https://github.com/apache/datafusion/pull/19674#issuecomment-3757969719
hi @adriangb,
Thanks for your research.
Recommendations for Aligning with DuckDB
> 1. Require at least one matching field - Eliminate positional fallback
entirely
I agree with this.
However, I would like to `Eliminate positional fallback entirely` in a
follow up PR so users who are relying on the current positional casting
behavior, can isolate this behavior change easily.
> 2. Consider case-insensitive matching - DuckDB treats x and X as matching
I would like to create an issue for this because Arrow's field name matching
is case-sensitive.
> 3. Add validation for missing non-nullable fields - If target field is
non-nullable but missing from source, error instead of filling with NULL
[Agree](https://github.com/apache/datafusion/pull/19674/commits/aa04deda6991f8fe62dee622199e36693da43a0e).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
