adriangb commented on PR #18252: URL: https://github.com/apache/datafusion/pull/18252#issuecomment-3781217724
Up to you. Smaller PRs are generally easier to review. E.g. if we were doing this again I'd suggest doing the change one crate at a time. So maybe fix the upstream issues then we come back and make a series of PRs to swap the macros one crate at a time. Given there's so many conflicts in this PR it may be best to declare bankruptcy... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
