2010YOUY01 commented on code in PR #19977:
URL: https://github.com/apache/datafusion/pull/19977#discussion_r2726465819
##########
datafusion/physical-expr-common/src/metrics/value.rs:
##########
@@ -985,19 +985,20 @@ impl MetricValue {
"row_groups_pruned_statistics" => 5,
"row_groups_pruned_bloom_filter" => 6,
"page_index_rows_pruned" => 7,
- _ => 8,
+ "page_index_pages_pruned" => 8,
Review Comment:
nit: this order is from coarse-grained to fine-grained pruning for `explain
analyze` display, so I think the order should be swapped:
```rust
"page_index_pages_pruned" => 7,
"page_index_rows_pruned" => 8,
```
##########
docs/source/user-guide/explain-usage.md:
##########
@@ -226,6 +226,7 @@ Again, reading from bottom up:
When predicate pushdown is enabled, `DataSourceExec` with `ParquetSource`
gains the following metrics:
Review Comment:
I agree this is not accurate, but it's a minor issue so it's fine to leave
it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
