ethan-tyler commented on code in PR #19884:
URL: https://github.com/apache/datafusion/pull/19884#discussion_r2729292426
##########
datafusion/sql/src/statement.rs:
##########
@@ -1070,6 +1070,13 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
plan_err!("Multiple tables in UPDATE SET FROM not yet
supported")?;
}
let update_from = from_clauses.and_then(|mut f| f.pop());
+
+ // UPDATE ... FROM is currently not working
+ // TODO fix https://github.com/apache/datafusion/issues/19950
+ if update_from.is_some() {
+ return not_impl_err!("UPDATE ... FROM is not supported");
Review Comment:
Minor inconsistency: multi-table `FROM` (L1070) returns `plan_err!("Multiple
tables...")` while single-table `FROM` (L1077) returns `not_impl_err!`.
Consider unifying- any `UPDATE ... FROM` → `not_impl_err!` making error
handling is consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
